feat(ecs): rename ephemeral → nonPersistent#129
Merged
Conversation
47-round autotune sweep on the adobe/data monorepo. Upstream winners lower the reranker confidence threshold, floor, and candidate windows; shift NL queries toward semantic (rrf_semantic_weight_nl 1.5, bm25 0.5); and expand evidence budgets. Learned-ranker blend set to 0.5 (v16). Net result vs defaults: NDCG@5 +0.030, NL@5 +0.070, Filtered@5 +0.022, Ident@5 unchanged. Config is repo-wide and inherited by all worktrees. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Add `Entity.isNonPersistent` and `Entity.isPersistent`; keep `isEphemeral` as `@deprecated` alias - Replace `TransactionResult.ephemeral` (bool: all changes are non-persistent) with `TransactionResult.persistent` (bool: at least one change is persistent) — breaking change - Add `Schema.nonPersistent` field; keep `Schema.ephemeral` as `@deprecated` alias - Add `OptionalComponents.nonPersistent`; keep `"ephemeral"` component string with runtime `console.warn` for backward compat - Update coalesce logic: `ephemeral: prev && cur` → `persistent: prev || cur` - Bump to 0.9.70 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Removes the false-antonym pairing with `persistent`. Both fields are now
clearly orthogonal: `intermediate` = commit lifecycle stage (preview vs.
final), `persistent` = entity storage category (positive-id vs. negative-id).
- `TransactionResult.transient` → `intermediate`
- `TransactionOptions.transient` → `intermediate`
- `TransactionIntent "transient"` → `"intermediate"` (wire protocol kind)
- `ClientMessage { kind: "transient" }` → `{ kind: "intermediate" }`
- `maxTransientsPerSecond` → `maxIntermediatesPerSecond`
- Fixes stale `result?.ephemeral` guard in create-sync-service → `result !== undefined && !result.persistent`
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…rce descriptors Schema has no transient field; the 34 occurrences across data-gpu plugins were dead metadata. Aligned with the Schema.nonPersistent field introduced alongside the ephemeral → nonPersistent rename. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TransactionResult.ephemeral(all-non-persistent bool) withTransactionResult.persistent(any-persistent bool) — breaking change, opposite semanticsEntity.isNonPersistent+Entity.isPersistent; keepisEphemeralas@deprecatedaliasSchema.nonPersistentfield; keepSchema.ephemeralas@deprecatedaliasOptionalComponents.nonPersistent;"ephemeral"component string still accepted at runtime withconsole.warnephemeral: prev && cur→persistent: prev || curTest plan
pnpm run typecheckpasses (verified locally)pnpm run lintpasses (verified locally)persistentassertionspersistent: truein TransactionResult fixturesisNonPersistent/isPersistentunit tests pass🤖 Generated with Claude Code